[Backup] az backup restore files mount-rp: fetch ILR mount scripts via dedicated list action - #34073
Open
Himanshu Agarwal (hiaga) wants to merge 3 commits into
Open
Himanshu Agarwal (hiaga) wants to merge 3 commits into
Himanshu Agarwal (hiaga) wants to merge 3 commits into
Conversation
…a dedicated list action Retrieve Instant Item Recovery (ILR) mount scripts through the dedicated ListInstantItemRecoveryOperationResult action instead of reading them from the provision operation-status response, so iSCSI CHAP connection details are no longer exposed in the broad ILR status payload. Bump the azure-mgmt-recoveryservicesbackup dependency from ~=9.2.0 to ~=11.1.0 and migrate the backup module to the unified client namespace (the activestamp/passivestamp split was removed) and the uppercase enum members. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d420238-f921-4e0f-ac6d-9acd4ed164b8
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
September 14, 2026 03:08
microsoft-github-policy-service
Bot
added
Auto-Assign
Copilot started reviewing on behalf of
Himanshu Agarwal (hiaga)
September 14, 2026 03:08
View session
Collaborator
|
Backup |
setup.py now requires ~=11.1.0 for the ILR list-action flow, but the frozen requirements.py3.*.txt files still pinned ==9.2.0, causing ResolutionImpossible in azdev CI. Align all three platform requirement files with setup.py. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d420238-f921-4e0f-ac6d-9acd4ed164b8
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Packaged CLI requirement files still pin SDK 9.2.0 and must be updated to 11.1.0.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates az backup restore files mount-rp to retrieve ILR mount scripts through the dedicated action and migrates Azure Backup to SDK 11.1.0.
Changes:
- Migrates Backup SDK clients, imports, models, and enums.
- Adds dedicated ILR script retrieval and renewal-flow tests.
- Updates dependency metadata and release history.
File summaries
| File | Summary |
|---|---|
src/azure-cli/setup.py |
Updates the SDK dependency; platform requirement files still pin 9.2.0 (critical finding, 3 votes). |
src/azure-cli/HISTORY.rst |
Documents the ILR change. |
src/azure-cli/azure/cli/command_modules/backup/tests/latest/test_backup_commands.py |
Adds ILR flow and SDK signature tests. |
src/azure-cli/azure/cli/command_modules/backup/custom.py |
Retrieves scripts through the dedicated list action. |
src/azure-cli/azure/cli/command_modules/backup/custom_wl.py |
Migrates workload backup SDK usage. |
src/azure-cli/azure/cli/command_modules/backup/custom_help.py |
Updates ILR status and operation handling. |
src/azure-cli/azure/cli/command_modules/backup/custom_common.py |
Migrates shared SDK usage. |
src/azure-cli/azure/cli/command_modules/backup/custom_base.py |
Migrates client and enum references. |
src/azure-cli/azure/cli/command_modules/backup/custom_afs.py |
Migrates Azure Files SDK usage. |
src/azure-cli/azure/cli/command_modules/backup/_validators.py |
Migrates storage enum usage. |
src/azure-cli/azure/cli/command_modules/backup/_client_factory.py |
Uses the unified Backup SDK client. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| 'azure-mgmt-rdbms==10.2.0b17', | ||
| 'azure-mgmt-mysqlflexibleservers==1.1.0b3', | ||
| 'azure-mgmt-recoveryservicesbackup~=9.2.0', | ||
| 'azure-mgmt-recoveryservicesbackup~=11.1.0', |
Contributor
There was a problem hiding this comment.
Incorrect, all 3 are updated.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
# Conflicts: # src/azure-cli/azure/cli/command_modules/backup/custom.py # src/azure-cli/azure/cli/command_modules/backup/custom_afs.py # src/azure-cli/azure/cli/command_modules/backup/custom_base.py # src/azure-cli/azure/cli/command_modules/backup/custom_help.py # src/azure-cli/requirements.py3.Darwin.txt # src/azure-cli/requirements.py3.Linux.txt # src/azure-cli/requirements.py3.windows.txt # src/azure-cli/setup.py
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌AzureCLI-FullTest
Related command
az backup restore files mount-rpDescription
Retrieve Instant Item Recovery (ILR) mount scripts through the dedicated
ListInstantItemRecoveryOperationResultaction instead of reading them from the provision operation-status response. This aligns the CLI with the service change that redacts iSCSI CHAP connection details from the broad ILR operation-status payload, so the mount credentials are only returned by the dedicated action.This bumps
azure-mgmt-recoveryservicesbackupfrom~=9.2.0to~=11.1.0. That SDK unifies the previously splitactivestamp/passivestampclient namespaces into a singleazure.mgmt.recoveryservicesbackupclient and switches enum members to upper-case, so the backup module imports and enum references were migrated accordingly. Cross Region Restore models that are not present in the new package are guarded so the module continues to import.Note: the new
list_instant_item_recovery_operation_resultoperation takesresource_group_namebeforevault_name(new ARM ordering), whereas the existingprovision/revokeoperations keepvault_namefirst. The call uses keyword arguments to make this explicit, and a unit test binds the call against the installed SDK signature to guard against future parameter reordering.Testing
Added unit tests covering the provision -> list flow, the active-session renewal path, and a signature-binding guard against the installed SDK.
History Notes
[Backup]
az backup restore files mount-rp: Fetch ILR mount scripts through the dedicated list action for CHAP credential redaction.